Skip to content

OSDOCS-14356: Added bond best practices to the networking docs #92458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSDOCS-14356: Added bond best practices to the networking docs #92458

wants to merge 1 commit into from

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Apr 22, 2025 •
edited
Loading

Checklist of items:

  • static DHCP requirements
  • fail_over_mac=1
  • OVS bonding
  • autoconnect-priority
  • Setting MTU on underlying interfaces
  • xmit_hash_policy

Version(s):
4.12+

Issue:
OSDOCS-14356

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-14356 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-14356 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
OSDOCS-14356

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 22, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 22, 2025 •
edited
Loading

🤖 Wed May 07 15:04:19 - Prow CI generated the docs preview:
https://92458--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-14356 which is a valid jira issue.

In response to this:

Version(s):
4.12+

Issue:
OSDOCS-14356

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2025
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-14356 which is a valid jira issue.

In response to this:

Checklist of items:

  • static DHCP requirements
  • fail_over_mac=1

Version(s):
4.12+

Issue:
OSDOCS-14356

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the OSDOCS-14356 branch 2 times, most recently from de8257b to 86e60a4 Compare May 7, 2025 10:14
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-14356 which is a valid jira issue.

In response to this:

Checklist of items:

  • static DHCP requirements
  • fail_over_mac=1
  • OVS bonding

Version(s):
4.12+

Issue:
OSDOCS-14356

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-14356 which is a valid jira issue.

In response to this:

Checklist of items:

  • static DHCP requirements
  • fail_over_mac=1
  • OVS bonding
  • autoconnect-priority

Version(s):
4.12+

Issue:
OSDOCS-14356

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-14356 which is a valid jira issue.

In response to this:

Checklist of items:

  • static DHCP requirements
  • fail_over_mac=1
  • OVS bonding
  • autoconnect-priority
  • Setting MTU on underlying interfaces
  • xmit_hash_policy (which do we test, do they all even work?)

Version(s):
4.12+

Issue:
OSDOCS-14356

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-14356 which is a valid jira issue.

In response to this:

Checklist of items:

  • static DHCP requirements
  • fail_over_mac=1
  • OVS bonding
  • autoconnect-priority
  • Setting MTU on underlying interfaces
  • xmit_hash_policy

Version(s):
4.12+

Issue:
OSDOCS-14356

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the OSDOCS-14356 branch 2 times, most recently from 2a0d6c2 to b7dfe8c Compare May 7, 2025 11:37
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-14356 which is a valid jira issue.

In response to this:

Checklist of items:

  • static DHCP requirements
  • fail_over_mac=1
  • OVS bonding
  • autoconnect-priority
  • Setting MTU on underlying interfaces
  • xmit_hash_policy

Version(s):
4.12+

Issue:
OSDOCS-14356

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-14356 which is a valid jira issue.

In response to this:

Checklist of items:

  • static DHCP requirements
  • fail_over_mac=1
  • OVS bonding
  • autoconnect-priority
  • Setting MTU on underlying interfaces
  • xmit_hash_policy

Version(s):
4.12+

Issue:
OSDOCS-14356

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

https://gitlab.cee.redhat.com/rbrattai/notes/-/blob/master/BondingNotes.md

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2025 •
edited by openshift-ci bot
Loading

@dfitzmau: This pull request references OSDOCS-14356 which is a valid jira issue.

In response to this:

Checklist of items:

  • static DHCP requirements
  • fail_over_mac=1
  • OVS bonding
  • autoconnect-priority
  • Setting MTU on underlying interfaces
  • xmit_hash_policy

Version(s):
4.12+

Issue:
OSDOCS-14356

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed May 7, 2025
View reviewed changes
modules/virt-example-nmstate-multiple-interfaces.adoc
@@ -7,6 +7,11 @@

You can create multiple interfaces in the same node network configuration policy. These interfaces can reference each other, allowing you to build and deploy a network configuration by using a single policy manifest.

[IMPORTANT]
====
If the multiple interfaces use the same default configuration, a single Network Manager connection profile activates on multiple interfaces simultaneously and this causes connections to have the same universally unique identifier (UUID). To avoid this issue, ensure that each interface has a specific configuration that is different to the default configuration.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.TermsErrors: Use 'different from' rather than 'different to'. For more information, see RedHat.TermsErrors.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 7, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.20 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).

If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @bergerhoffer @openshift-merge-robot @ocpdocs-vale-bot